Added an onAnimationEnd listener to the startAnimation() function

leandroBorgesFerreira / LoadingButtonAndroid

A button to substitute the ProgressDialog

MIT License

1.94k stars 214 forks source link

Added an onAnimationEnd listener to the startAnimation() function #118

Closed NicolasDucom closed 5 years ago

NicolasDucom commented 5 years ago

I also fixed a bug in applyAnimationEndListener() that would add a new listener for every click on the button, tell me what you think !

leandroBorgesFerreira commented 5 years ago

The PR looks fine. Just one thing: This library uses 4 spaces for continuation instead of 8 spaces (this is the default for ktlint), just fix the lint and we can merge it =]

leandroBorgesFerreira commented 5 years ago

fixes #118

leandroBorgesFerreira commented 5 years ago

By the way, use ./gradlew build to see the ktlint results

NicolasDucom commented 5 years ago

@leandroBorgesFerreira I'm having a bit of trouble seeing where the issue is with the latest build (not used to using Travis for integration testing). I'm not having any trouble when running the tests on my PC. Would you mind taking a look at the Travis log ?

leandroBorgesFerreira commented 5 years ago

The instrumented tests are falling, this is a false positive and it is already present, you don't have to fix it.