search

leandroBorgesFerreira / LoadingButtonAndroid

A button to substitute the ProgressDialog
MIT License
1.94k stars 214 forks source link

ProgressButton is now Lifecycle-aware #121

Closed wokkaflokka closed 5 years ago

wokkaflokka commented 5 years ago

ProgressButton instances now implement LifecycleObserver and register for lifecycle events on construction. The only event observed is onDestroy, which now automatically disposes animations whenever the LifecycleOwner is destroyed.

Closes #102

leandroBorgesFerreira commented 5 years ago

The code looks fine. Sorry that I am taking forever to merge your PR, I am moving to another country and I am away these last days

wokkaflokka commented 5 years ago

No worries -- moving is a pain, I imagine it's even more exhausting when moving to another country.

I've been meaning to circle back on this and look at the failing build -- seems like some of the earlier CI changes I made might now be broken.

leandroBorgesFerreira commented 5 years ago

The problems with the CI is not yours. I created some flaky tests and I'm going to correct it once I can. No worries.