search

leandroBorgesFerreira / LoadingButtonAndroid

A button to substitute the ProgressDialog
MIT License
1.94k stars 214 forks source link

Background drawable setting re-implemented #123

Closed przemekpan closed 5 years ago

przemekpan commented 5 years ago

I've changed approach to background drawable fetching and settings. This allows usage of all(at least I think it should cover all drawables). Background is now optional if for example style with background is used. I've also added test case to show how it works and rest of test seems to be working fine.

Additionally this should fix issues #120, #42, #34. Also there was a bug where background in other buttons where changed during or after animation background because framework is caching background drawable.

leandroBorgesFerreira commented 5 years ago

Hello @ookamip.

Thanks for contributing to this library!

I am moving from Brazil to Germany in this next week, so I am busy to review your PR. I will do it after this week. Sorry for the inconvenience.

leandroBorgesFerreira commented 5 years ago

hello @ookamip. Do you have any plans to update your PR? Your contribution is really nice

przemekpan commented 5 years ago

hello @leandroBorgesFerreira sorry about delay I were on little vacation trip so I had no chance to work on it. But now I'm back so I will update it today or tomorrow. I'm glad that you find it useful :)

bbowman commented 5 years ago

@ookamip @leandroBorgesFerreira any updates here?

przemekpan commented 5 years ago

@bbowman hey sorry about delay but I had a crazy last two weeks. I'll work on it now :)

przemekpan commented 5 years ago

@leandroBorgesFerreira I updated PR and left some comments please check them and let me know what do you think about them

leandroBorgesFerreira commented 5 years ago

Hi. I'll take a look this next week.

leandroBorgesFerreira commented 5 years ago

Finally merged!! Thanks for your contribution to this library! This was a great PR.