search

leandroBorgesFerreira / LoadingButtonAndroid

A button to substitute the ProgressDialog
MIT License
1.94k stars 214 forks source link

Nullable AttributeSet #187

Closed NicholasMata closed 1 year ago

NicholasMata commented 2 years ago

AttributeSet should be made nullable, as all views have nullable AttributeSet for programmatic use.

AppCompatButton and AppCompatImageButton allow for nullable AttributeSet and ProgressButton.init allows for nullable AttributeSet as well.

The only change that is to the constructors for CircularProgressButton and CircularProgressImageButton

leandroBorgesFerreira commented 1 year ago

Hello Nicholas.

Sorry for the really late reply. I was busy with personal matters and I could not take a look at your PR =|. When I was bumping the dependencies so I can publish this library again, but this time in Sonatype, I end up fixing this constructor. I didn't see that you already suggested a fix in your PR.

Thank you a lot for taking the time to fix this problem in the constructor and, again, I'm sorry for not taking a look at your PR. I hope to see you again in this or other open source projects =]