search

leandrocfe / filament-apex-charts

Apex Charts integration for Filament PHP.
https://filament-apex-charts-demo.leandroferreira.dev.br
MIT License
300 stars 38 forks source link

Fix duplicate database queries #13

Closed howdu closed 1 year ago

billmn commented 1 year ago

@leandrocfe Can this PR be merged?

leandrocfe commented 1 year ago

@leandrocfe Can this PR be merged?

Hi, Sure. Could you explain this issue please?

billmn commented 1 year ago

@leandrocfe Can this PR be merged?

Hi, Sure. Could you explain this issue please?

Without this change the getOptions method was called twice, so we have duplicated queries for every chart.

leandrocfe commented 1 year ago

@leandrocfe Can this PR be merged?

Hi, Sure. Could you explain this issue please?

Without this change the getOptions method was called twice, so we have duplicated queries for every chart.

Ok, I'll check. Thank you 👍

billmn commented 1 year ago

@leandrocfe Great, thank you!