leandrocfe / filament-apex-charts

Apex Charts integration for Filament PHP.
https://filament-apex-charts-demo.leandroferreira.dev.br
MIT License
324 stars 39 forks source link

Fix single select filter reactivity issue #48

Closed margarizaldi closed 8 months ago

margarizaldi commented 11 months ago

Fix issue #39

Hopefully reviewed soon @leandrocfe because I really love this package. ❤️

leandrocfe commented 10 months ago

@margarizaldi I think you can use filter forms to achieve this.

margarizaldi commented 10 months ago

@leandrocfe if I only need the functionality, yes I will use filter form, but sometimes we need a more straightforward and simpler filter, and visible. Also my clients are happier to use simple select for their dashboard page. 🙂

Any problem with the change?

leandrocfe commented 8 months ago

Please check the new version and make a new PR if it was necessary

sairiz commented 8 months ago

The new version doesnt fix it. This PR is fixing the single filter update issue. Quite unnecessary to create another same PR.

The thing is livewire have change their default 'live' setting. Version 2 has the 'live' update by default but version 3 required live to be explicit. So this simple fix is the default fix as well.