search

leandrogehlen / yii2-querybuilder

Extension for Yii2 Framework to work with jQuery QueryBuilder
43 stars 34 forks source link

add Bootstrap 4 support #22

Closed hoaaah closed 3 years ago

leandrogehlen commented 3 years ago

Thanks for PR. I think this is not a good choice. Maybe should better remove Bootstrap dependency and the developer can do this choice in your project

hoaaah commented 3 years ago

This PR is quick fix when you want to use BS4 instead of BS3 that comes with Yii2 by default. Of course this is an options to use BS4, if developer want to stick with BS3 they can easily ignore bsVersion params.

Without this PR, developer who wants to use BS4 can't use this extension because it keeps call BS3 Asset.