search

leandromoreira / digital_video_introduction

A hands-on introduction to video technology: image, video, codec (av1, vp9, h265) and more (ffmpeg encoding). Translations: 🇺🇸 🇨🇳 🇯🇵 🇮🇹 🇰🇷 🇷🇺 🇧🇷 🇪🇸
https://github.com/leandromoreira/introduction_video_technology
BSD 3-Clause "New" or "Revised" License
15.52k stars 1.33k forks source link

Generate debug video Example doesn't run #100

Closed gdavila closed 4 years ago

gdavila commented 4 years ago

I'm triying to run the example provided in debug video Example to generate a debug video with macro blocks. But I get the next error:

[NULL @ 0x9219c0] Unable to parse option value "vis_mb_type"
[NULL @ 0x9219c0] Error setting option debug to value vis_mb_type.
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x91ff80] Failed to open codec in avformat_find_stream_info
[NULL @ 0x922d40] [Eval @ 0x7ffd11e97290] Undefined constant or missing '(' in 'vis_mb_type'
[NULL @ 0x922d40] Unable to parse option value "vis_mb_type"
[NULL @ 0x922d40] Error setting option debug to value vis_mb_type.

The image that docker runs from jrottenberg/ffmpeg contanis:

ffmpeg version 4.1 Copyright (c) 2000-2018 the FFmpeg developers
built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.11) 20160609
leandromoreira commented 4 years ago

Hey @gdavila how is goin'?

I think you're facing this error due to the fact that vis_mb_type is only supported by 10/17 FFmpeg's release.

The following sections apply to ffmpeg versions older than October 21 2017.

gdavila commented 4 years ago

Thanks @leandromoreira. I suspected it, but given that any ffmpeg version/tag was specified on the docker cmd, I was not sure. Maybe the docker cmd in s/ffmpeg file should point to the image where this feature is supported.

leandromoreira commented 4 years ago

Totally @gdavila =/ I'll let this open so when I have a free time or anybody else can do a PR to solve this.

gdavila commented 4 years ago

I've added the right tag to the ffmpeg Docker Image and send a PR . As far as I could check, the PR shouldn't affect the rest of the provided examples.

leandromoreira commented 4 years ago

thank you very much, I merged