search

leandromoreira / digital_video_introduction

A hands-on introduction to video technology: image, video, codec (av1, vp9, h265) and more (ffmpeg encoding). Translations: 🇺🇸 🇨🇳 🇯🇵 🇮🇹 🇰🇷 🇷🇺 🇧🇷 🇪🇸
https://github.com/leandromoreira/introduction_video_technology
BSD 3-Clause "New" or "Revised" License
15.52k stars 1.33k forks source link

Proofread a Japanese translation #68

Closed c-bata closed 6 years ago

c-bata commented 6 years ago

First, thanks for creating this awesome repository @leandromoreira. And also thanks for translating into Japanese @thmatuza! I hope more Japanese people will read this.

I proofread a Japanese translation. @thmatuza Could you review this?

c-bata commented 6 years ago

[nits] I think it's better to put this at translations/README-ja.md or japanese/README.md to avoid duprecations. If you agree, I'll rename and push it on this branch.

Now I noticed there is a Chinese translation. If we will rename this file, Chinese translation should also be renamed. If you agree, I'll submit a new pull request.

thmatuza commented 6 years ago

@c-bata Thank you for proofreading my translation! It looks good to me except following part.

AVC (H.264)標準は、情報がNAL

If you see it on markdown preview, you may notice it doesn't emphasis NAL but ❇︎❇︎ remains. (I tried it on Chrome) I had to put a space before and/or after ❇︎❇︎ for fixing those Japanese markdown problems.

c-bata commented 6 years ago

Thanks for your review! I fixed it like:

2018-07-08 21 07 33
thmatuza commented 6 years ago

Looks good to me! LGTM

leandromoreira commented 6 years ago

I liked the suggestion of using translations/ and move all the translations and change their links in the main README.