leandrowkz / acmeframework-php

ACME Framework is a CodeIgniter powerful small application with a lot of features ready-to-use like login, users, permissions, menus, a powerful API and more.
http://acmeframework.codecomplex.io
27 stars 9 forks source link

Error Checking Database in Version 2.3.12 #19

Closed mynolix closed 9 years ago

mynolix commented 9 years ago

Hi! I think you have an error in app_installer.php (Line 271, for mysql-Driver)

It must be: if( get_value($result, 'COUNT_DATABASE') < 0 ) return lang('Schema not exists:') . ' ' . $db_database . ' '; But you have: if( get_value($result, 'COUNT_DATABASE') > 0 ) return lang('Schema already exists:') . ' ' . $db_database . ' ';

This is, why nobody can get to the Step2 in the installation prcess!

leandrowkz commented 9 years ago

Hi @mynolix, thanks for your reply.

This happens on purpose in this version (2.3.12) because the installer attempts to create database automatically. So you do not have to worry creating the database manually as you can see on line 430 from app_installer.php:

$this->dbforge->create_database($db_database);

But, unfortunately there are many webservers which does not allow creating databases directly from code. Also we see that similar projects which have installation process like Wordpress, Drupal, etc. do not do this. So because of that we changed this behavior on version 3.0.0 of ACME, exactly in the same way you explained.

Please download latest version of ACME (branch master) and try again. In a few days we going to publish a new tag release and update ACME Framework website as well.