search

leanflutter / auto_updater

This plugin allows Flutter desktop apps to automatically update themselves (based on sparkle and winsparkle).
MIT License
285 stars 41 forks source link

Windows Releasenotes open in the browser when calling autoUpdater.checkForUpdates #56

Closed Justus-M closed 1 year ago

Justus-M commented 1 year ago

When I call checkForUpdates, the Release notes box in the winsparkle dialog is blank, and the release notes link is automatically opened in the browser instead of showing the html file inside the Winsparkle Dialog.

I don't have this issue on Mac, and everything else seems to work on windows except for this.

Here is my appcast item (with some information removed)

<item>
            <title>Version 1.7.26</title>
            <sparkle:releaseNotesLink>
                https://staging.blazesql.com/releasenotes.html
            </sparkle:releaseNotesLink>
            <pubDate>Thu, 29 Aug 2023 18:30:07 +0200</pubDate>
            <enclosure url="removed"
                       sparkle:dsaSignature="removed"
                       sparkle:version="12"
                       sparkle:os="windows"
                       length="0"
                       type="application/octet-stream" />
        </item>
Screenshot 2023-08-29 at 14 29 31
Justus-M commented 1 year ago

https://github.com/vslavik/winsparkle/issues/252

The appcast releasenotes opening and closing tags as well as the link need to be on the same line.

I suggest you update the example appcast.xml accordingly, and also add the hostname to the .exe link.

Both of these things in the example file are fine for mac, but cause issues for windows.