leanflutter / flutter_distributor

An all-in-one Flutter application packaging and distribution tool, providing you with a one-stop solution to meet various distribution needs.
https://distributor.leanflutter.dev/
MIT License
772 stars 106 forks source link

Add support to specify build architecture for deb release #123

Closed animator closed 1 year ago

animator commented 1 year ago

Fix for Linux deb packager highlighted in #116

Users can now specify build architecture - arm64, amd64 (default if not specified) in the make_config.yaml file via build_arch option (same option name as used by rpm maker)

Tested it by building foss42/api-dash linux builds.

animator commented 1 year ago

No idea why lint / format (pull_request) failed 🤷🏻‍♀️

lijy91 commented 1 year ago

I think the arch should not be specified by the user, but should be obtained from the current system, just like this. https://github.com/leanflutter/flutter_distributor/blob/6daea51056d48287a6a437be5e77d45611b09a31/packages/flutter_app_builder/lib/src/builders/linux/build_linux_result.dart#L18-L28

animator commented 1 year ago

The reason I took this route is because it requires minimum code changes and gives more control to the user as arm64 and amd64 are just two architectures, there are plenty more which the current getter in builders/linux/build_linux_result.dart does not handle. Let me know your thoughts.