Feat/macos builder support flavor

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

shubhamsinghmutualmobile commented 3 weeks ago

@lijy91 Is there a way for me to test this new code? I am using this:

fvm dart pub global activate -sgit https://github.com/leanflutter/flutter_distributor.git --git-path packages/flutter_distributor/ --git-ref 0abe930d073c0d679038a00c09e4388e5e55ebd8 --overwrite

but getting the following error:

Because every version of flutter_distributor from git depends on flutter_app_builder ^0.4.4 which doesn't match any versions, flutter_distributor from git is forbidden.
So, because pub global activate depends on flutter_distributor from git, version solving failed.

lijy91 commented 3 weeks ago

Try this

git clone git@github.com:leanflutter/flutter_distributor.git
cd flutter_distributor
gh pr checkout 196
melos bs
melos activate

shubhamsinghmutualmobile commented 3 weeks ago

Try this

git clone git@github.com:leanflutter/flutter_distributor.git
cd flutter_distributor
gh pr checkout 196
melos bs
melos activate

Still doesn't seem to work for me :( Do you think I might be doing something wrong?

lijy91 commented 3 weeks ago

Can you try build the multiple_flavors example

cd examples/multiple_flavors 
./release.sh dmg-release

lijy91 commented 3 weeks ago

Please provide a screenshot of your scheme configuration, And your build/macos/Build/Products directory.

Logs for ./release.sh dmg-release:

===> Releasing dmg-release:dev
Packaging multiple_flavors 1.0.0+1 as dmg:
$ /Users/lijy91/fvm/versions/3.22.2/bin/flutter build macos --flavor dev --dart-define FLUTTER_BUILD_NAME=1.0.0 --dart-define FLUTTER_BUILD_NUMBER=1

Building macOS application...                                   
--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:macOS, arch:arm64, id:00006000-0004199C0A22401E, name:My Mac }
{ platform:macOS, arch:x86_64, id:00006000-0004199C0A22401E, name:My Mac }
✓ Built build/macos/Build/Products/Release-dev/multiple_flavors.app (28.9MB)
{
  "config": {
    "mode": "release",
    "flavor": "dev",
    "arguments": {
      "flavor": "dev"
    }
  },
  "outputDirectory": "build/macos/Build/Products/Release-dev",
  "duration": 5763,
  "outputFiles": [
    "./build/macos/Build/Products/Release-dev/multiple_flavors.app"
  ]
}
Successfully built Directory: 'build/macos/Build/Products/Release-dev' in 5s
$ cp -RH build/macos/Build/Products/Release-dev/multiple_flavors.app dist/1.0.0+1/multiple_flavors-dev-1.0.0(1)-macos_dmg
$ cp -RH macos/packaging/dmg/. dist/1.0.0+1/multiple_flavors-dev-1.0.0(1)-macos_dmg
$ appdmg dist/1.0.0+1/multiple_flavors-dev-1.0.0(1)-macos_dmg/make_config.json dist/1.0.0+1/multiple_flavors-dev-1.0.0(1)-macos.dmg

shubhamsinghmutualmobile commented 3 weeks ago

Try this

git clone git@github.com:leanflutter/flutter_distributor.git
cd flutter_distributor
gh pr checkout 196
melos bs
melos activate

I did not realise that the command gh pr checkout 196 did not work for me. Hence, I was using the main branch to build the plugin 🤦 Apologies for that. I just verified that this PR is working fine on my project as well ✅

Although I see a new problem now i.e.

Error on line 10, column 16: Expected a key while parsing a block mapping.
   ╷
10 │     path: [DEV]Ember.app
   │                ^
   ╵

but I believe that's not a part of this discussion. We can discuss it in another issue.

For now, thank you for your quick support on this feature! 🙌

leanflutter / flutter_distributor

Feat/macos builder support flavor #196