Open AminBhst opened 1 week ago
My current workaround is to add a job step that replaces the icon path to the proper explicit value:
make_config.yaml:
app_id: 5B599538-42B1-4826-A479-AF079F21A65D
publisher: Amin Beheshti
publisher_url: https://github.com/AminBhst/brisk
display_name: Brisk
create_desktop_icon: true
install_dir_name: "{autopf}\\Brisk"
setup_icon_file: PLACEHOLDER_ICON_PATH
locales:
- en
This step added to the workflow file:
- name: Set proper icon path
run: |
$iconPath = "${{ github.workspace }}\\assets\\icons\\logo.ico"
(Get-Content windows/packaging/exe/make_config.yaml) -replace 'PLACEHOLDER_ICON_PATH', $iconPath | Set-Content windows/packaging/exe/make_config.yaml
Hello. The setup_icon_file property is nowhere to be found in the documentation but I did find a merge request that added this property. Here is my make_config.yaml
After running the workflow with the
setup_icon_file
set, it results in a build failure:The exe is built eventually, however, the file is corrupted as it failed during the build. The crazy thing is that the icon is properly set for the corrupted exe file. It does work fine if I set the path explicitly like this:
setup_icon_file: D:\\a\\brisk\\brisk\\assets\\icons\\logo.ico
. However, this is obviously not ideal. Is there any way to use${{ github.workspace }}
for flutter distributor?