search

leangen / geantyref

Advanced generic type reflection library with support for working with AnnotatedTypes (for Java 8+)
Apache License 2.0
99 stars 15 forks source link

No module name described in MANIFEST #10

Closed gselzer closed 4 years ago

gselzer commented 4 years ago

For those using JPMS, it would be nice if geantyref contained an Automatic Module Name (see here for reasons why). This would provide a stable module name that other projects can reference, and is a very small change on the part of geantyref (see here).

kaqqao commented 4 years ago

I was looking into this myself. I'm currently unable to actively work on my projects, but if you'd take this upon yourself I'd happily merge and release it. If not, I'll eventually resume active work and take care of this, but can't give promises about the time line.

gselzer commented 4 years ago

@kaqqao I would be happy to add it. Do you have any preferences about the module name? I would assume io.leangen.geantyref?

kaqqao commented 4 years ago

Yup, looks good! Merged, thanks!

A248 commented 3 years ago

@kaqqao I don't mean to bug you about a release, but you did say you'd release a minor version with Automatic-Module-Name. This issue is a pretty significant blocker for any modular application, so it'd be nice if that release could arrive in the nearer future, if you have the spare time of course.