search

leangen / graphql-spqr-spring-boot-starter

Spring Boot 2 starter powered by GraphQL SPQR
Apache License 2.0
276 stars 68 forks source link

Spring Boot 3 Support? #133

Closed ErtugrulSener closed 1 year ago

ErtugrulSener commented 1 year ago

Anyone knows if we can use graphql-spqr with Spring Boot 3? Is there any plans on doing that?

Could I maybe help, by just "testing" if this works and pointing out what needs to be changed? Maybe even do some changes?

kaqqao commented 1 year ago

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change). I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to use it while I'm working on the new stuff... I'll do this by next weekend.

ErtugrulSener commented 1 year ago

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change).

I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to using it while I'm working on the new stuff... I'll do this by next weekend.

That sounds awesome! ❤️

ErtugrulSener commented 1 year ago

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change).

I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to use it while I'm working on the new stuff... I'll do this by next weekend.

Hey @kaqqao - You still working on that? You need a helping hand?

russm3086 commented 1 year ago

Technically, only one single line needs to change (apart from bumping the dependency versions) to make it compatible with Spring Boot 3 (javax -> jakarta package change). I have somewhat lofty goals for the next version of the starter, and am knee-deep in that. But instead of finishing all that before I release a Spring Boot 3 compatible version, I should just make the minimal changes and publish an intermediary release to enable people to use it while I'm working on the new stuff... I'll do this by next weekend.

Hey @kaqqao - You still working on that? You need a helping hand?

Any update?

manshanb commented 1 year ago

@kaqqao Any update on this ? As springboot 2.7 is nearing End of Life, upgrade to Springboot 3 is critical for us.

mdtamim commented 1 year ago

@kaqqao I see code changes related to Spring Boot 3 has been merged to the main branch.Can you please release a major version also so that we can start pulling that dependency from Maven repo?

ErtugrulSener commented 1 year ago

The PR by @SaschaPeukert has been accepted, now we need a new version. Should we choose "1.0.0" as this is a major update?

@kaqqao

kaqqao commented 1 year ago

Should we choose "1.0.0" as this is a major update?

I... don't know 😓 The version after this will be based on the Spring GraphQL starter, so another major change... I either name this 1.0.0 and the next 2.0.0 already, or we still keep 0.x even though this is a big change... I don't like either proposition too much 🫤 What do you say?

mdtamim commented 1 year ago

I don't have issues with 0.x but would vote to go with major release version ie.. 1.0.0 because it follows Semantic Versioning rule

ErtugrulSener commented 1 year ago

I don't have issues with 0.x but would vote to go with major release version ie.. 1.0.0 because it follows Semantic Versioning rule

Do we have breaking changes? Yes, since the java ee namespace is called jakarta now, so the user can't use the new version without changes on his code.

So following SemVer it should be "1.0.0". Versions don't cost anything, if the change to Spring GraphQL Starter has breaking changes for the user again, it will be "2.0.0", so what. It's okay I think, Mozilla / Chrome has Versions 100+ and nobody cares 💫

kaqqao commented 1 year ago

Ok. This release will be 1.0.0 (making 1.x the classic SPQR Starter branch) and the Spring GraphQL starter based ones will be 2.x. Seems nice and intuitive enough.

kaqqao commented 1 year ago

Released v1.0.0