search

leangen / graphql-spqr

Build a GraphQL service in seconds
Apache License 2.0
1.09k stars 181 forks source link

Upgrade to graphql-java 17.X #423

Closed kurenchuksergey closed 1 year ago

kaqqao commented 2 years ago

Hi! Thanks a bunch for this! I'm currently traveling but will look over and merge this when I'm back (couple of weeks).

kurenchuksergey commented 1 year ago

Thank @samwhile that you mention me and wake up, I will return to MR on these weekends

ср, 5 окт. 2022 г. в 05:43, samwhile @.***>:

@.**** commented on this pull request.

In pom.xml https://github.com/leangen/graphql-spqr/pull/423#discussion_r987491112:

@@ -98,7 +98,12 @@

com.graphql-java graphql-java - 16.2 + 17.3

@kurenchuksergey https://github.com/kurenchuksergey Can you consider bumping this to 17.4 to include changes that resolves a recent vulnerability https://github.com/advisories/GHSA-v62j-cxhh-fq22?

— Reply to this email directly, view it on GitHub https://github.com/leangen/graphql-spqr/pull/423#pullrequestreview-1130825528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3ET3XKAA5AZNQ5SNRDUPLWBTTN5ANCNFSM5YNHCZ3A . You are receiving this because you were mentioned.Message ID: @.***>

-- Куренчук Сергей http://adventgroup.ru/ http://advent.com.ua ADVENT - Мы не ищем легких путей

kaqqao commented 1 year ago

I'm grateful to everyone involved, but I've opted to upgrade straight to graphql-java v19. See #433. I'll close this PR in light of that. New release coming soon. If anyone cares to test the current master against their project before the release, I'd be grateful.