search

leanphp / behat-code-coverage

Generate Code Coverage reports for Behat tests
BSD 2-Clause "Simplified" License
50 stars 23 forks source link

Added coverage flag #24

Closed dannylewis-sheffield closed 6 years ago

dannylewis-sheffield commented 6 years ago

Generating code coverage is slow so I've added flag --coverage to the command to generate reports if set, if it's not set it informs the user of how to set the flag. This is inline with the PHPUnit way of enabling coverage reports.

ek9 commented 6 years ago

Thanks for the PR. The functionality is good, however I am vary against changing the default behaviour for existing users. While keeping in sync with phpunit's option would be nice, however we should not change existing default behaviour. It might be best to first introduce --skip-coverage parameter, so existing users would not need to make any changes.

Also the tests are failing, I will merge it later with some changes.

Thank you for contribution.