leanprover-community / lean4game

Server to host lean games.
https://adam.math.hhu.de
GNU General Public License v3.0
172 stars 29 forks source link

test dev container #156

Open joneugster opened 9 months ago

joneugster commented 9 months ago

We should have a github action testing the dev-container is working.

This would probably be a second "job" in this github action: GameSkeleton build.yml

liyongsea commented 9 months ago

So each game has their own github action to check the dev container ? Will it be too complicated to maintain ?

joneugster commented 9 months ago

There is a github action in each game. It is this one: https://github.com/hhu-adam/GameSkeleton/blob/main/.github/workflows/build.yml

(Arguably, this issue should be there, but I'd prefer having all issues here...)

Concretely, I think one can add a second job to this github action which does the following:

It's the second two steps that I have no idea if they are feasible and how you would do that.

joneugster commented 9 months ago

Regarding the maintaining question, the instructions currently are simply that game devs need to copy these files from the GameSkeleton if they want the newest features:

See Updating a Game

I think this is okay as is and I don't see an alternative

abentkamp commented 7 months ago

There are frameworks such as selenium or puppeteer that can test the functionality of a website as a whole.