leanprover-community / mathlib3

Lean 3's obsolete mathematical components library: please use mathlib4
https://leanprover-community.github.io/lean3
Apache License 2.0
1.67k stars 298 forks source link

documenting mathlib #1260

Open robertylewis opened 5 years ago

robertylewis commented 5 years ago

We have instituted new documentation requirements for mathlib additions: https://github.com/leanprover-community/mathlib/pull/1229

It is a long term effort to bring the existing mathlib code base up to these standards. New pull requests will be responsible for updating parts of the library that they touch, within reason. But we strongly encourage everyone to add documentation for parts of the library they have created or are familiar with.

The following files have no headers at all:

But at the moment, nearly all of mathlib needs updating. So pick a random file and there's likely work to be done.

A useful tool: the #doc_blame #lint only doc_blame user command prints all definitions above it in the current file that are missing doc strings. doc_blame! includes theorems and lemmas.

Update, April 4, 2020

#lint shows missing documentation now, instead of #doc_blame. All linter failures in the library can be seen here: https://github.com/leanprover-community/mathlib/blob/master/scripts/nolints.txt

Update, Dec 6, 2021

We've made good progress. Here is a list of style exceptions, including files that are missing module docs. Every file has at least a copyright header.

kim-em commented 5 years ago

I addressed some of these in #1264.

cipher1024 commented 5 years ago

I should probably take care of