leanprover-community / mathlib4

The math library of Lean 4
https://leanprover-community.github.io/mathlib4_docs
Apache License 2.0
1.5k stars 331 forks source link

Porting note: `simp` / `@[simp]` can prove it #10618

Open pitmonticone opened 8 months ago

pitmonticone commented 8 months ago

Classifies porting notes claiming anything semantically equivalent to

Related to: #11119

Examples

https://github.com/leanprover-community/mathlib4/blob/4b36afcf085586739aa4e59d507a7d01d9a2dbbf/Mathlib/Algebra/AddTorsor.lean#L194-L198

https://github.com/leanprover-community/mathlib4/blob/4b36afcf085586739aa4e59d507a7d01d9a2dbbf/Mathlib/Algebra/CubicDiscriminant.lean#L236-L239

https://github.com/leanprover-community/mathlib4/blob/4b36afcf085586739aa4e59d507a7d01d9a2dbbf/Mathlib/Algebra/Module/Basic.lean#L257-L260

https://github.com/leanprover-community/mathlib4/blob/76e9597c4920fd0421f70311e28cfc396367a5d1/Mathlib/Algebra/GCDMonoid/Basic.lean#L136-L146

pitmonticone commented 8 months ago

Regarding these porting note

https://github.com/leanprover-community/mathlib4/blob/4b36afcf085586739aa4e59d507a7d01d9a2dbbf/Mathlib/CategoryTheory/Limits/IsLimit.lean#L571

@kbuzzard said:

What is going on with this one? Is this a bug in the simpNF linter?

pitmonticone commented 8 months ago

Regarding these porting note

https://github.com/leanprover-community/mathlib4/blob/4b36afcf085586739aa4e59d507a7d01d9a2dbbf/Mathlib/CategoryTheory/Limits/Shapes/Biproducts.lean#L261

@kbuzzard said:

What is going on with this one?

pitmonticone commented 8 months ago

Regarding these porting note

https://github.com/leanprover-community/mathlib4/blob/4b36afcf085586739aa4e59d507a7d01d9a2dbbf/Mathlib/Data/Vector.lean#L249

@kbuzzard said:

Is this the correct solution for this problem?