leanprover-community / mathlib4

The math library of Lean 4
https://leanprover-community.github.io/mathlib4_docs
Apache License 2.0
1.57k stars 342 forks source link

Deduplicate signs #7842

Open urkud opened 1 year ago

urkud commented 1 year ago

We have SignType.sign, Int.sign, and Real.sign. Probably, we should deduplicate them.

loefflerd commented 9 months ago

See my comments on #10883: we cannot replace Int.sign with anything derived from SignType.sign, since Int.sign is in std, not in mathlib.

urkud commented 7 months ago

We can backport SignType.sign to Std, if

OTOH, I don't know if it will be accepted in Std.