Closed eric-wieser closed 2 months ago
Do you consider also removing Coe String Html
? I don't know if it's implicitly used.
Merging this broke the mathlib4_docs site, please fix this, test it and open the PR again.
Merging this broke the mathlib4_docs site, please fix this, test it and open the PR again.
By "broke" do you mean "caused the build to fail" or "produced garbage output"?
The top bar is now visually broken and using the search feature does not work anymore, probably because some escaping broke stuff. As reported here by users: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Documentation.20loading.20issue/near/443714091
I think I can look at this later, but not today...
I fixed this in #192
The
.text
constructor was a misnomer, as this was not a "text node" in the sense that HTML/DOM defines the phrase.This renames
text
toraw
(which it appears is only needed in one place) and adds a newtext
(with escape-on-output semantics) that is used in almost every other place.Without this change,
results in javascript injection.
The
instance : ToString Html
is removed because this makes it too easy to accidentally doubly-escape something.