Closed mkckr0 closed 1 year ago
Pull requests without meaningful description are not acceptable
Description has been updated.
There is already a call to term.carriage_return()
, is it clear why that doesn't work? When in doubt, please instead port over fixes from rustup upstream, who seem to have relevant changes.
Rustup implements a new terminal interface by themself. They also use ANSI escape code \r
or \x0d
to achieve carriage return.
Copying this file and dealing with all dependencies and references is a hard work. So I only copy some snippets, and use \r
directly.
For filling spaces with a carriage return, it is because last line may be longer than next line, then the trailing chars may still be showed. So filling a fixed quantity of spaces is not enough in this case. Use displayed_charcount
to count the spaces of last line instead.
Okay, looks reasonable to me. Thanks for investigating.
I assume you sucessfully tested it on Windows?
Okay, looks reasonable to me. Thanks for investigating.
I assume you sucessfully tested it on Windows?
Yes, it's latest Windows 10.
Looks good on Linux as well
The download progress is bad displayed. Add carriage return (\x0d) to fix it.