search

leanprover / fp-lean

Functional Programming in Lean
Other
71 stars 20 forks source link

[Typo] "Changesets" in section 4.5 #171

Open mars0i opened 4 days ago

mars0i commented 4 days ago

Please quote the complete incorrect sentence - this makes it easy to find in the source code of the book.

From https://lean-lang.org/functional_programming_in_lean/type-classes/standard-classes.html#deriving-standard-classes

Changesets involving updates to datatypes are easier to read without line after line of formulaic modifications to equality tests and hash computation.

"Changesets" looks like a typo: the word doesn't appear elsewhere in FPIL. Maybe should be "changes"? (I don't think it's a reference to https://github.com/changesets/changesets.)

Thank you!

david-christiansen commented 2 days ago

It is indeed a reference to that! Would it have been more clear if I'd written "diffs"?

mars0i commented 2 days ago

Ah, I see. I'm not a full-time programmer, and I find that sometimes there is terminology, or tools, that are well-used but new to me. I'd never seen "changeset", and that repo and clones of it were the only apparently relevant instances of "changeset" that I found in a cursory search. Yes, "diff" would have been clear for me, but if "changeset" is common, my ignorance shouldn't be a reason not to use it. I'm an outlier. I imagine that a Lean newbie coming from math probably wouldn't know either term, but that's not the target audience of FPIL.