leanprover / lean4

Lean 4 programming language and theorem prover
https://lean-lang.org
Apache License 2.0
3.88k stars 329 forks source link

feat: getLsb_sshiftRight #4179

Closed bollu closed 18 hours ago

bollu commented 2 weeks ago

In the course of the development, I grabbed facts about right shifting over integers from mathlib4.

The core proof strategy is to perform a case analysis of the msb:

bollu commented 2 weeks ago

awaiting-review

leanprover-community-mathlib4-bot commented 2 weeks ago

Mathlib CI status (docs):

bollu commented 2 weeks ago

awaiting-review

bollu commented 1 week ago

awaiting-review

semorrison commented 6 days ago

Many stylistic comments, but I'm now satisfied that the main proof really requires this much talking about Int.negSucc! Hopefully we can merge soon.

tobiasgrosser commented 6 days ago

awaiting-author

bollu commented 5 days ago

@semorrison I've cleaned up the proof, thanks a lot for your detailed stylistic comments.

bollu commented 5 days ago

awaiting-review