leanprover / lean4

Lean 4 programming language and theorem prover
https://lean-lang.org
Apache License 2.0
4.74k stars 427 forks source link

feat: add `BitVec.(msb, getMsbD)_(rotateLeft, rotateRight)` #6120

Closed luisacicolini closed 6 days ago

luisacicolini commented 1 week ago

This PR adds theorems BitVec.(getMsbD, msb)_(rotateLeft, rotateRight).

We follow the same strategy taken for getLsbD, constructing the necessary auxilliary theorems first (relying on different hypotheses) and then generalizing.

leanprover-community-bot commented 1 week ago

Mathlib CI status (docs):

kim-em commented 6 days ago

@luisacicolini, just a quick request re: the PR description. Thanks for adding a paragraph beginning "This PR ..." --- we know automatically extract these to incorporate in the draft release notes. Having PR authors write them saves us lots of time! But it means that things like "cc: @bollu" need to go in a separate paragraph, otherwise they may end up in the release notes!

luisacicolini commented 6 days ago

got it @kim-em! And thanks for reviewing this :)