leanprover / theorem_proving_in_lean4

Theorem Proving in Lean 4
https://leanprover.github.io/theorem_proving_in_lean4/
Apache License 2.0
159 stars 85 forks source link

Suggestions for clarity #114

Open turibe opened 5 months ago

turibe commented 5 months ago

Suggestions to clarify some possibly confusing items. Main ones are:

avigad commented 4 months ago

@turibe @jdchristensen I apologize that it has taken me so long to find time to catch up on the PR and the discussion in #112. David is right that I am protective of things I have written, and I appreciate the sensitivity that both of you have shown. I have read over @turibe's proposed changes and they are generally very good. It's often hard to judge changes in isolation, but I plan to come back to TPIL soon to make revisions, so I think it makes sense to merge this PR as is, given that I'll have a chance to tinker with the text later.

jdchristensen commented 4 months ago

@avigad Did you maybe mean to tag @david-christiansen instead of me?

avigad commented 4 months ago

Indeed, I did -- sorry for the mistake!