search

leanprover / tutorial

Lean Tutorials
https://leanprover.github.io/tutorial
Apache License 2.0
44 stars 46 forks source link

Fix non-loading page on iOS 10 #205

Closed glangmead closed 7 years ago

glangmead commented 7 years ago

Move jquery libraries to be included first. Work around https://github.com/webcomponents/webcomponentsjs/issues/617 by trying webcomponents-lite. With these changes, after "make", I can load the site on Safari for Mac (macOS 10.12.1) as well as Safari on iPad, iOS 10.

gebner commented 7 years ago

With the lite version I get an error here because Platform.ShadowCSS is not defined. Then the code snippets in the text are not visible (using chromium here).

Can you see these code snippets in safari?

2016-11-22-171042_1920x1080_scrot

glangmead commented 7 years ago

I see them, but only the first one in a chapter is styled correctly. The others lack styling and line breaks, which is not good. Guess it'll need the real fix to webcomponents?

gebner commented 7 years ago

Have you tried the latest 0.7.23 release? As far as I can tell from the git log, it should include the fix for this issue.

glangmead commented 7 years ago

Aha! Thanks, the thread for issue 617 over at webcomponents did not make that obvious. By rolling back the -lite change and updating to 0.7.23 things look good and the styling of the code samples is back.

gebner commented 7 years ago

Awesome! Could you squash all four commits into one and change the commit message according to the convention here, i.e. something like fix(index.html,header/html.org): support safari? I'll merge it then. Thank you.

glangmead commented 7 years ago

I opened a new cleaner PR with one commit over here: https://github.com/leanprover/tutorial/pull/205. Closing this one.