In #469, I refactored the abbreviation provider to maintain one abbreviation rewriter per visible text editor. The idea was that it would be nice if the abbreviation state was maintained when switching between visible text editors.
It turns out that this is way too fiddly to get right:
Since TextEditors have no ID, it relies on the fact that TextEditor references are stable. I'm not sure if this is actually true, and I don't want to debug issues that are caused by this assumption being violated.
The abbreviation rewriters for two text editors for the same text can trample over one another.
The benefit isn't huge. We already always replace abbreviations when the selection is moved away from the abbreviation, so why shouldn't this also be the case when moving the cursor across text editors?
Still, the new behavior is a bit more consistent than the behavior before #469, as it correctly deals with changed language IDs and triggers abbreviations when moving the cursor away from the editor (instead of simply unselecting the abbreviation).
This PR also ensures that exceptions during the activation of the extension are displayed in a modal dialog. An exception at this point always breaks the extension for the user, so they should know about it (and the error shouldn't be hidden away in the developer console).
In #469, I refactored the abbreviation provider to maintain one abbreviation rewriter per visible text editor. The idea was that it would be nice if the abbreviation state was maintained when switching between visible text editors.
It turns out that this is way too fiddly to get right:
TextEditors have no ID, it relies on the fact thatTextEditorreferences are stable. I'm not sure if this is actually true, and I don't want to debug issues that are caused by this assumption being violated.Still, the new behavior is a bit more consistent than the behavior before #469, as it correctly deals with changed language IDs and triggers abbreviations when moving the cursor away from the editor (instead of simply unselecting the abbreviation).
This PR also ensures that exceptions during the activation of the extension are displayed in a modal dialog. An exception at this point always breaks the extension for the user, so they should know about it (and the error shouldn't be hidden away in the developer console).
Fixes #478.