leap-stc / ClimSim

An open large-scale dataset for training high-resolution physics emulators in hybrid multi-scale climate simulators.
https://leap-stc.github.io/ClimSim/
Apache License 2.0
138 stars 40 forks source link

Increase unit test coverage of `data_utils` to > 95% #24

Open cisaacstern opened 1 year ago

cisaacstern commented 1 year ago

Our current test coverage of climsim_utils.data_utils is 12%, as seen here:

https://github.com/leap-stc/ClimSim/actions/runs/5898192566/job/15998878076#step:5:43

That is not surprising because our only test is a smoke test for importability:

https://github.com/leap-stc/ClimSim/blob/f7d092cbaf57d79d47fa56dc0fd3e00a391da696/tests/test_data_utils.py#L5-L6

We should increase unit test coverage of data_utils to establish a benchmark of functionality before attempting any refactoring, such as proposed in #17. 95% or greater coverage would be a strong basis to shoot for.