Closed NoraLoose closed 1 year ago
Just throwing it out there, both of those guidelines can be enforced programmatically by GitHub branch protection rules that could be applied to main
(PR required, review required, etc.).
Not to assume we can't also have "voluntary compliance" 😆 but actually such rules can be helpful for (a) remembering to re-enforce good habits; and (b) prevent mistakes (e.g., pushing to main from the terminal accidentally).
Just happened to see this. Agree with all the suggestions here. I'm okay with programmatic enforcement, and I apologize for pushing to main / merging my own pull requests.
Added a GitHub branch protection rule that enforces pull requests. We can add more if you'd like.
@NoraLoose @cisaacstern
Thanks Jerry! That's great.
Can we agree on the following guidelines for how to contribute to this GitHub repo?
main
.I'm tagging the currently main contributors to this repo. Please give a thumbs-up if you agree to these guidelines. @jerrylin96 @cisaacstern @NoraLoose