Set up PR vs production configs for the deploy action

leap-stc / LEAP_template_feedstock

A Prototype feedstock that implements independent metadata and data updates using pangeo forge

Apache License 2.0

1 stars 2 forks source link

Set up PR vs production configs for the deploy action #38

Open jbusecke opened 1 year ago

jbusecke commented 1 year ago

We are currently building the full recipe for every commit (if a label is set).

I think we should have some things set in two different config jsons based on the event type:

Push to main:
- Prune set to false
- Set a permanent directory in leap-persistent-rofor each recipe and subfolders for each action run
PR:
- Prune set to true
- Write resulting data to temporary storage (e.g. leap-scratch)

cisaacstern commented 1 year ago

This could be achieved with conditionals in the workflow file (and no changes needed to the action). Or it could be a PR to the action. Either seems doable.

jbusecke commented 1 year ago

I would think the first option is more flexible right now? I guess we really need some more users of the action to see how we might properly generalize this?

cisaacstern commented 1 year ago

I would think the first option is more flexible right now?

Agreed. A relatively manageable path forward would be to use a github workflow step that conditionally exports either env vars (or workflow step outputs) based on the github event type, which can then be inserted into the pangeo-forge-runner JSON config.

cisaacstern commented 1 year ago

In leap-stc/data-management#33, I currently have the following parts of this working:

Push to main:

[x] Prune set to false
[ ] Set a permanent directory in leap-persistent-ro for each recipe and subfolders for each action run

PR:

[x] Prune set to true
[ ] Write resulting data to temporary storage (e.g. leap-scratch)