leap-stc / data-management

Collection of code to manually populate the persistent cloud bucket with data
https://catalog.leap.columbia.edu/
Apache License 2.0
0 stars 5 forks source link

adding Jerry's notebook for troubleshooting #1

Closed jerrylin96 closed 1 year ago

jerrylin96 commented 1 year ago

Notebook I added shows errors in the rest of the notebook I have. Thankfully, importing is no longer an issue, although I noticed that I have to explicitly import zarr and dask.

jbusecke commented 1 year ago

@andersy005 do you have any insight why pre-commit is not autofixing things automatically?

jbusecke commented 1 year ago

pre-commit.ci autofix

jbusecke commented 1 year ago

Oh I see you turned it off in the config. Any particular reason why?

jbusecke commented 1 year ago

Hi @jerrylin96 sorry for the delay here. I see that you submitted two notebooks? Was that intended?

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jbusecke commented 1 year ago

The xarray_to_zarr_jerry seems to have a bunch of errors. Was this from a test run?

andersy005 commented 1 year ago

@andersy005 do you have any insight why pre-commit is not autofixing things automatically?

i have currently disabled this feature, but i don't have a strong opinion on enabling it.

https://github.com/leap-stc/data-management/blob/a5d74870f30041a2b8e438545f4d72f7ba1b8b49/.pre-commit-config.yaml#L3