search

leap-stc / data-management

Collection of code to manually populate the persistent cloud bucket with data
https://catalog.leap.columbia.edu/
Apache License 2.0
0 stars 5 forks source link

Linter question ruff vs black #10

Closed jbusecke closed 1 year ago

jbusecke commented 1 year ago

@andersy005 @katamartin thanks for working on improving the CI here. I was just curious about the code linter setup with pre-commit: Why are we using both ruff and black? Am I wrong in thinking that ruff replaces black for most parts? Maybe this is just for linting notebooks with black-jupyter?

andersy005 commented 1 year ago

My understanding is that ruff is not necessary a replacement for black

Per the docs: https://beta.ruff.rs/docs/faq/#is-ruff-compatible-with-black

As a project, Ruff is designed to be used alongside Black and, as such, will defer implementing stylistic lint rules that are obviated by autoformatting.

jbusecke commented 1 year ago

Oh interesting! Thanks for the link and correction!