search

leapcode / pysqlcipher

Python bindings for SQLCipher
https://leap.se
Other
131 stars 42 forks source link

Fix for invalid concatenated path causing install to fail in OpenBazaar #14

Closed sammiejenkins closed 9 years ago

sammiejenkins commented 9 years ago

This fixes an issue when trying to install the latest version of OpenBazaar

kalikaneko commented 9 years ago

thanks for reporting @sammiejenkins
just merged (the fix was in master but not in develop)

yagoulas commented 9 years ago

Is there any plan to update the version hosted in pypi? Right now the latest version is 2.6.3-1 which still doesn't use the safe url.

dionyziz commented 9 years ago

This is critical for our deployment purposes and breaks our build for OpenBazaar. If this does't get on pypi, we have to host pysqlcipher ourselves.

kalikaneko commented 9 years ago

@yagoulas @dionyziz this fix is already in pypi since november or so: pip install pysqlcipher==2.6.4 (see https://github.com/leapcode/pysqlcipher/issues/13#issuecomment-62883428)

I didn' receive a confirmation, but I think I forgot to make it the default one anyhow. Can you confirm that 2.6.4 is working for you? I'll make it the default release after a confirmation on osx, I cannot test on that platform.

sammiejenkins commented 9 years ago

2.6.4 worked for me on Windows 8.1

kalikaneko commented 9 years ago

thanks @sammiejenkins! I'll wait for @dionyziz or somebody else confirmation on osx. If I get no notice in a couple of days I'll make it the default release, and we'll see if something breaks :)

dionyziz commented 9 years ago

Works for me on mac.

kalikaneko commented 9 years ago

@dionyziz thanks for testing! I've just made it the default release.