Amalgamation site is down - Not working with pip - Githubissues

leapcode / pysqlcipher

Python bindings for SQLCipher

https://leap.se

Other

131 stars 42 forks source link

Amalgamation site is down - Not working with pip #28

Closed abhaybhargav closed 8 years ago

abhaybhargav commented 8 years ago

this url: for the amalgamation download is down, causing pip installs to fail

mdomke commented 8 years ago

Wouldn't it be better to vendor the dependencies into the package instead of downloading somewhere from the internet?

ScottSturdivant commented 8 years ago

Additionally, if building against the system libraries (python setup.py build_sqlcipher), then attempting to install via python setup.py install still winds up triggering build_ext, which in turn uses https://github.com/leapcode/pysqlcipher/blob/develop/setup.py#L159, resulting in an unecessary attempt to fetch (a now down) amalgamation url.

kalikaneko commented 8 years ago

apologies, the server that holds the amalgamation is down due to an outage. service will be resumed soon.

Wouldn't it be better to vendor the dependencies into the package

we want to make the bundling optional and disabled by default. building against system lib should be preferred. you can also build the amalgamation from upstream sqlcipher and put it on a folder.

Additionally, if building against the system libraries (python setup.py build_sqlcipher), then attempting to install via python setup.py install still winds up

attempting to install via python setup.py install still winds up triggering build_ext

looks like a bug

kalikaneko commented 8 years ago

I will push a new version shortly, vendoring the bundle and making compilation about the system lib the default. some testing will be appreciated before pushing to pypi.

kalikaneko commented 8 years ago

with commit 3fd5e3d5e9785 this should be solved.

it vendors the amalgamation
it builds against system-wide libsqlcipher by default
it allows to build against bundled sqlcipher, using --bundled
it allows to pass a path to a different amalgamation

Some testing would be greatly appreciated. I will push a new version to pypi in some minutes doing these changes.

kalikaneko commented 8 years ago

@SirScott do you mind testing installation from master at 3fd5e3d ?

kalikaneko commented 8 years ago

I have pushed version 2.6.6 to pypi. this version doesn't try to download the amalgamation by default.

ScottSturdivant commented 8 years ago

@kalikaneko: That worked for me, thank you!