leapcode / pysqlcipher

Python bindings for SQLCipher
https://leap.se
Other
131 stars 42 forks source link

set CFLAGS to -Qnoused-arguments to allow osx build #9

Closed kalikaneko closed 10 years ago

kalikaneko commented 10 years ago

DO NOT merge yet. need testing

kalikaneko commented 10 years ago

I wonder what can be a better strategy for when clang decides that these errors cannot be skipped... I guess that one will have to fiddle with the CCompiler class in distutils?

chiiph commented 10 years ago

python setup.py install worked in OSX 10.9.4

kalikaneko commented 10 years ago

@dionyziz @gubatron can you confirm this builds correctly within your environments? (and specify Xcode and clang versions please?)

gubatron commented 10 years ago

@kalikaneko I need some help with git. I just cloned the project, but how can I checkout this pull request?

gubatron commented 10 years ago

tried this, but can't checkout this "bug/clang-unused-args" branch

gubatrons-macbook-pro-3:pysqlcipher gubatron$ git fetch bug/clang-unused-args
fatal: 'bug/clang-unused-args' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
gubatrons-macbook-pro-3:pysqlcipher gubatron$ git checkout bug/clang-unused-args
error: pathspec 'bug/clang-unused-args' did not match any file(s) known to git.
gubatrons-macbook-pro-3:pysqlcipher gubatron$ git fetch --all
Fetching origin
gubatrons-macbook-pro-3:pysqlcipher gubatron$ git branch
* develop
gubatrons-macbook-pro-3:pysqlcipher gubatron$ git branch --all
* develop
  remotes/origin/HEAD -> origin/develop
  remotes/origin/android
  remotes/origin/debian
  remotes/origin/develop
  remotes/origin/master
gubatron commented 10 years ago

did this do it?

git fetch origin pull/9/head
remote: Counting objects: 6, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 6 (delta 1), reused 4 (delta 1)
Unpacking objects: 100% (6/6), done.
From http://github.com/leapcode/pysqlcipher
 * branch            refs/pull/9/head -> FETCH_HEAD
gubatrons-macbook-pro-3:pysqlcipher gubatron$ git diff
gubatrons-macbook-pro-3:pysqlcipher gubatron$ ls -l
total 96
-rw-r--r--   1 gubatron  macports    892 Sep 10 23:31 LICENSE
-rw-r--r--   1 gubatron  macports    233 Sep 10 23:31 MANIFEST.in
-rw-r--r--   1 gubatron  macports    290 Sep 10 23:31 README.rst
-rw-r--r--   1 gubatron  macports  13886 Sep 10 23:31 cross_bdist_wininst.py
drwxr-xr-x   3 gubatron  macports    102 Sep 10 23:31 doc
drwxr-xr-x   6 gubatron  macports    204 Sep 10 23:31 lib
-rw-r--r--   1 gubatron  macports    138 Sep 10 23:31 setup.cfg
-rw-r--r--   1 gubatron  macports  12594 Sep 10 23:31 setup.py
drwxr-xr-x  22 gubatron  macports    748 Sep 10 23:31 src
kalikaneko commented 10 years ago

@gubatron that doesn't seem to match what's in this branch. I normally add a remote for each contributor, and then fetch that remote and checkout a specific branch to fiddle around. In your example you still need to checkout to the fetched branch (note that you can give a nicer branchname)

git fetch origin pull/ID/head:BRANCHNAME
[master] $ git checkout BRANCHNAME
gubatron commented 10 years ago

thanks that did it, testing right away

$ git fetch origin pull/9/head:bug/clang-unused-args
From http://github.com/leapcode/pysqlcipher
 * [new ref]         refs/pull/9/head -> bug/clang-unused-args
$ git checkout bug/clang-unused-args
Switched to branch 'bug/clang-unused-args'
gubatron commented 10 years ago

worked perfectly.

kalikaneko commented 10 years ago

worked perfectly. cool, thanks. I'll tag a new release and update the package in pypi then.