leapdao / EthereumMachineOracle

8 stars 4 forks source link

Write tests for Oracle contract #22

Closed roleengineer closed 4 years ago

roleengineer commented 4 years ago

Bounty

Add tests for Oracle contract and improve existing tests.

Scope

remove temporary solutions
implement setTimeout function for Client contract
make waffle chai matchers work, if possible (ethersjs Array format)
optimize existing tests
cover all require statements with unit tests

Deliverables

Tests

Funding Circle

General

Bounty Owner/Gardener

@roleengineer as EMO developer

Gain for the Role

EMO roadmap progress

Roles

bounty gardener: @roleengineer / 0 DAI bounty worker: @roleengineer / 80% bounty reviewer: @TheReturnOfJan / 20%

Gardener checklist

[x] I have attached one of the size- labels to this bounty
[x] I have submitted this bounty via http://bounty.leapdao.org/viewform
[x] I have added this bounty to bounty board here https://github.com/orgs/leapdao/projects/6

roleengineer commented 4 years ago

resolved https://github.com/leapdao/EthereumMachineOracle/pull/21