leapdao / leap-core

library for tx and block signing
GNU Affero General Public License v3.0
15 stars 5 forks source link

get rid of node-fetch dependency #149

Closed troggy closed 5 years ago

sunify commented 5 years ago

Why?

troggy commented 5 years ago

It is an extra dependency needed only for a very niche feature (fast exit). E.g. we are using leap-core in many scripts just for crunching data and have to drag node-fetch as well.

Probably, the better solution would be to extract exit market maker things in a separate package

On a bright side, node-fetch has no dependencies itself 🎉, so maybe not a big deal.

sunify commented 5 years ago

https://bundlephobia.com/result?p=node-fetch@2.6.0 441B in a bundle for browsers 🤷‍♂

troggy commented 5 years ago

best package ever :)