search

leapdao / leap-core

library for tx and block signing
GNU Affero General Public License v3.0
15 stars 5 forks source link

fix: add blockHeight to EpochLength tx to make them unique #155

Closed troggy closed 4 years ago

troggy commented 4 years ago

See leapdao/leap-node#349 for rationale.

With blockHeight injected several legit epoch length txs changing to the same value should have different raw bytes.

troggy commented 4 years ago

released as 0.36.2-beta for evaluating the fix in leap-node

troggy commented 4 years ago

@sunify I've also added strict checks for params to avoid mis-use like Tx.epochLength(2): https://github.com/leapdao/leap-core/pull/155/commits/2db8efd5c28835dc145da4bae7e74ab7e83dd9a2

sunify commented 4 years ago

Awesome! Looks good as well :-)