leapdao / leap-node

LeapDAO validation node

https://docs.leapdao.org

Mozilla Public License 2.0

15 stars 11 forks source link

Cannot increase epoch length #340

Closed troggy closed 4 years ago

troggy commented 4 years ago

Bounty

Probably related to #310.

To reproduce consider the following steps:

Run the local env (integration tests with yarn start). This will spin up two validator network with epoch length of 2.
Try to change epoch length to 3: submit and finalize a proposal to MinGov.
You get leap-node:error Wrong epoch length in logs and epoch length stays 2

Scope

try to reproduce the case with unit test
create an integration test to reproduce the issue
fix the code (probably checkEpochLength handler)

Deliverables

updated code
(possibly) updated integration tests
(possibly) updated tests

Reviewer checklist

[ ] review the code for logical correctness, inefficiencies and style (TBD)
[ ] ensure unit tests are passing
[ ] ensure code coverage is not reduced
[ ] ensure integration tests are passing for the PR branch

Gain for the project

Working multi-validator setup

Roles

bounty gardener: @troggy / 50 DAI bounty worker: @troggy / 80% bounty reviewer: name / 20%

Funded by

Dev Circle

troggy commented 4 years ago

PRs:

https://github.com/leapdao/leap-core/pull/155 (the crux)
https://github.com/leapdao/leap-node/pull/348
https://github.com/leapdao/integration-tests/pull/69 (test to reproduce the issue)
https://github.com/leapdao/leap-node/pull/349 (main writeup)