search

leapdao / plasma-burner-wallet

A secure Plasma web wallet for super fast money transfers.
https://peep.cash
MIT License
6 stars 5 forks source link

Link display currency to account #217

Closed MaxStalker closed 5 years ago

MaxStalker commented 5 years ago

This PR will cover issue #206

MaxStalker commented 5 years ago

Looks solid so far. I left a couple of comments however.

Thank you for review, Tim!

One major problem I still see with this PR is: We're now "live" with peep.cash, so we'll have to migrate user's "currency" settings to "currency" somehow. If possible, please add that to this PR.

I've added handler that will check if there was a value with name "currency" in localStorage.

MaxStalker commented 5 years ago

Thanks for adjusting the PR.

Unfortunately, I've spotted a second problem. It is that there's leftovers of the old localStorage.getItem("currency") implementation still in the code.

I think once you've replaced all of those, we should be good to merge.

Hm... can you point me to where you have found those? I have 0 occuracies found for "localStorage.get" in "src" folder here...