search

leapdao / solEVM-enforcer

Partial implementation of the Ethereum runtime in Solidity (PoC)
Mozilla Public License 2.0
98 stars 16 forks source link

implement Hofmann structure #169

Closed TheReturnOfJan closed 4 years ago

TheReturnOfJan commented 4 years ago

resolves https://github.com/leapdao/solEVM-enforcer/issues/118

troggy commented 4 years ago

why you are removing fixtures? 🤔

TheReturnOfJan commented 4 years ago

This is very much WIP. I made the PR so I have a nice diff to look at. I will announce when it's ready for review.

troggy commented 4 years ago

cool. go go go 🚀

johannbarbie commented 4 years ago

i have this one failing test:


  1) Runtime
       initAndExecute
         CALL transfer - successful transfer:

      AssertionError [ERR_ASSERTION]: tokenBag
      + expected - actual

seems easy to fix, need help?

TheReturnOfJan commented 4 years ago

Still WIP @johannbarbie. patience :)

TheReturnOfJan commented 4 years ago

Ok all tests now passing and it's cleaned up a bit. FIrst comments welcome!

johannbarbie commented 4 years ago 
JS Stepper
      1) STATICCALL balanceOf - successful read
      2) STATICCALL balanceOf - missed color
      3) STATICCALL balanceOf - missed address
      4) STATICCALL readData - successfull read
      5) CALL transfer - successfull transfer

i still have these guys failing. errors look like this:

  1) JS Stepper
       fixtures
         STATICCALL balanceOf - successful read:

      AssertionError [ERR_ASSERTION]: stack
      + expected - actual

       [
      -  "0x0000000000000000000000000000000000000000000000000000000000000000"
      +  "0x0000000000000000000000000000000000000000000000000000000000000001"
       ]
TheReturnOfJan commented 4 years ago

Yeah I noticed this after, seems like I need to update the off-chain stepper to behave the same.

johannbarbie commented 4 years ago

Yeah I noticed this after, seems like I need to update the off-chain stepper to behave the same.

is that even possible? or are we at a dead end here?

TheReturnOfJan commented 4 years ago

Why not possible? I just didn't even know it existed in this repo. Will do it tomorrow.