Closed Basanta78 closed 4 years ago
@Basanta78 One change request - we should follow more functional approach than OOP - it's more testable and loosely coupled. So, change your class implementation into plain functions. We might have classes in the future too but very less based on need where they fit in better.
We'll have packages and modules that expose mostly pure functions that are testable.
Take the reference from these:
@Basanta78 One change request - we should follow more functional approach than OOP - it's more testable and loosely coupled. So, change your class implementation into plain functions. We might have classes in the future too but very less based on need where they fit in better.
We'll have packages and modules that expose mostly pure functions that are testable.
Take the reference from these:
One up from me
@Basanta78 Mostly looks good to me. See my comments above - few path resolution needs changing.
And, failing builds. You need to fix your packages.
These two would be just modules not packages so you'll need to convert them to files from directories.