leapfrogtechnology / datamegh

Datamegh - Data Engineering for the cloud.
MIT License
2 stars 1 forks source link

Use formatting tool called Black - a standard python code formatter #3

Closed Basanta78 closed 4 years ago

Basanta78 commented 4 years ago

Current Behaviour

Standard formatting tool and linting tool has not been used in the repo to maintain the standard of the code. A common tool should be introduced in order to maintain a common coding standard.

Proposal

Note: The whole repo will be strictly black formatted code.

kabirbaidhya commented 4 years ago

Awesome. Thanks for adding this @Basanta78.

cc @shakyapranin

sbimochan commented 4 years ago

-n would skip the hook 😅

Basanta78 commented 4 years ago

Yes, -n will skip the hook. That's why we will be placing a black formatter checker in our CI which will error out with formatting error if the code has not been formatted with black and will stop the build. So, we will be strictly checking the standard of the code with the use of black.

sbimochan commented 4 years ago

That’s great to integrate in CI too.

kabirbaidhya commented 4 years ago

I agree - CI should fail if the code doesn't agree to our formatter.