leapfrogtechnology / reactjs-starter

5 stars 11 forks source link

Add search filter to react table #19

Closed anishmanandhar closed 4 years ago

anishmanandhar commented 4 years ago

REQUIREMENTS

Check this JSON server mock API for reference https://www.npmjs.com/package/json-server#filter

Screen Shot 2020-05-01 at 10 54 50 AM
sumansta commented 4 years ago

Can I take this? @pratishshr

pratishshr commented 4 years ago

sure @sumansta . Added you to the repo. @anishmanandhar Could you explain what kind of filter are we looking for in this issue?

anishmanandhar commented 4 years ago

@sumansta updated the description. please check it.

sumansta commented 4 years ago

@anishmanandhar Should the search API be triggered on inputChange or only when FilterList is clicked? Also, as there are firstName and lastName in db.json, do I need to handle the search by either of the name or a full name?

anishmanandhar commented 4 years ago

@sumansta lets search on input change, Add debounce capability also. Look at this article for reference https://levelup.gitconnected.com/debounce-in-javascript-improve-your-applications-performance-5b01855e086