search

leaphy-robotics / leaphy-blocks

The web-based visual programming editor.
Apache License 2.0
1 stars 0 forks source link

chore: minimize amount of blocks in function call #95

Closed koen1711 closed 2 months ago

rmoesbergen commented 2 months ago

Hmm, this doesn't make much sense to me. The block definition and generator are now in different locations (arduino.ts vs. leaphy_common.ts for example). Any why exactly is blocks being int the getBlocks() function a bad thing? Now if you need the board parameters for a block that didn't have them before, the blocks suddenly needs to move to a different file? Weird.

sverben commented 2 months ago

Hmm, this doesn't make much sense to me. The block definition and generator are now in different locations (arduino.ts vs. leaphy_common.ts for example). Any why exactly is blocks being int the getBlocks() function a bad thing? Now if you need the board parameters for a block that didn't have them before, the blocks suddenly needs to move to a different file? Weird.

eens

koen1711 commented 2 months ago

Hmm, this doesn't make much sense to me. The block definition and generator are now in different locations (arduino.ts vs. leaphy_common.ts for example). Any why exactly is blocks being int the getBlocks() function a bad thing? Now if you need the board parameters for a block that didn't have them before, the blocks suddenly needs to move to a different file? Weird.

We fix the long time not fixed issue of redefining every block.