Closed GabrielHare closed 9 years ago
Verified that scenes like 500 blocks work as expected when time warp and rewind are turned off. No offset artifacts or depth issues.
Verified that cubes in TESTRewind follow behind the camera rig as expected. Tuning the rewind amount correctly changes the amount of delay they experience.
For shaders: PassthroughBackground.shader PassthroughForeground.shader ThresholdOverlay.shader I am getting errors about exceeding constant register counts, making them target 3.0 fixes the issue. In each shader underneath right underneath the #pragma multi compile we should add #pragma target 3.0
Both LeapOVRCameraRig and QuickSwitchCameraRig have TimeWarp tweened all the way to 1.0 instead of 0.0. Should we have all of the prefabs use a value of 0.0 by default since things are still experimental?
LeapOVRPlayerController is tweened to 0.0.
@yuwilbur changes have been made to BugReporter and CameraRecorder - please review. @Amarcolina @RandomOutput keyboard controls have been made public, and require holding 1 button and pressing another to begin. Please review.
LeapCameraAlignment is still using [HideInInspector] for some of it's variables. Unless these are being set by a custom editor script I think we should be using [System.NonSerialized] for all public variables that we don't want to show up in the inspector.
Everything looks good to me! The two changes I commented about don't break any functionality or prevent testing and are pretty small anyway, and all the scenes had the desired effect from my testing
Looks good! Merging