Unity 5.2.0 / Oculus 0.7.0 Runtime VR Integration

[RandomOutput]

This PR Updates Core Assets to support Unity's embedded virtual reality support and the Oculus 0.7.0 Runtime.

Stakeholder Signoff

• [x] @protodeep
• [x] @Amarcolina
• [x] @yuwilbur
• [x] LM-QA

  Minimum Requirements

• Unity 5.2.0f1
• Oculus 0.7.0 Runtime
• Leap Motion 2.3.1+31549

  Addresses the following:

Fixes leapmotion/Front-End-Integrations#3 Fixes leapmotion/Front-End-Integrations#4 Fixes leapmotion/Front-End-Integrations#5 Fixes leapmotion/Front-End-Integrations#7 Fixes leapmotion/Front-End-Integrations#9 Fixes leapmotion/Front-End-Integrations#10 Fixes leapmotion/Front-End-Integrations#12

To Test:

Configuration Manager

• [x] Confirm that a LMHeadMountedRig can be configured for VR hands / VR world, AR hands / VR world, and AR hands / AR world from the configuration mananger.
• [x] Confirm that the LMHeadMountedRig can be changed and the configuration manager will not override that change without input from the user.
• [x] Confirm that the configuration manager properly reflects the left and right graphics model hands selected in the hand controller when in VR hands / VR world mode.

  Advanced Mode

• [x] Confirm that by setting advanced mode to true/false in the AdvancedMode.cs script, advanced fields in LeapCameraAlignment, LeapImageRetriever and LeapImageBasedMaterial are visible or not visible in the editor, respectively.

  Spacial / Temporal Alignment

• [x] Confirm that TweenTimewarp is set to 0 at runtime if a peripheral is detected. This is a temporary fix until peripheral firmware is fixed to enable accurate timecodes.
• [x] Confirm that alignment works properly with both Dragonfly and Peripheral modules. (You may need to override the device type as dragonfly in the advanced mode editor as the devices are not detected properly.)

  Scene Updates

• [x] Confirm that all scenes work properly with no regressions:
  • [x] 500 Blocks
  • [x] Bug Reporter
  • [x] Hand Viewer
  • [x] Moving Demo
  • [x] Quick Switch Demo
  • [x] Space Time Alignment
  • [x] VR Widgets

    Misc.

• [x] Confirm that old plugin-style OVRCameraRig plugins are no longer extant or referenced.

[protodeep]

Regarding: " Confirm that the configuration manager properly reflects the left and right graphics model hands selected in the hand controller when in VR hands / VR world mode."

If I swap the robot hands for other 3D hands on the HandController, the config manager overrides this at runtime. That intended?

[protodeep]

Also, I'm getting offset finger positions in my right hand when using 3D robot hands regardless of whether "Separate Left/Right" is checked.

[protodeep]

And, if I drag a GlowRobotFullRightHand onto the right hand slot of the HandController, it will pop back to whatever is in the left hand slot as soon as I click anywhere else in the editor.

[Kip27]

These scenes are crashing for me on play in-editor and when attempting to build with Unity 5.2.0 and Oculus runtime 0.7.0.0

[protodeep]

Override Device Type enum set to "Invalid". Intended?

[mmenicutch]

The issue with the apps crashing seems to be that the non VR scenes are outputting to the oculus when you have an oculus plugged into your system. It only causes a crash for some systems, others don't get hands or passthrough.

[protodeep]

Quickswitch on Dragonfly only switches by moving hand up, not down. Both directions work on peripheral

[Kip27]

ImageHands scene not working. Error: Cannot use LeapImageRetriever if there is no HandController! No images in-editor or when built.

[RandomOutput]

@protodeep: Commit 2d818ec should resolve:

• Hand override at runtime
• Left / Right hand model slot mismatch.
• Left / Right hand misalignment.
• The dragonfly quick switch issue is a separate problem and not a regression. The quickswitch code does not know how to deal with Dragonfly. @Amarcolina was considering fixing this at some point, but it hasn't been prioritized.
• The 'invalid' device override default is intended behavior. The device override should default to off.

@Kip27 @mmenicutch As discussed, for non-VR scenes, the oculus must be unplugged and/or 'virtual reality supported' must be disabled in the unity 'player settings' tab.

[RandomOutput]

@Kip27 9484ca7 should resolve the broken desktop image hands scene.

[mmenicutch]

It seems that anything involving keyboard controls in the oculus scenes no longer works, tab to start recording in the bug reporter scene and the WASD controls in the moving demo no longer function.

[mmenicutch]

I'm also seeing an issue with Quickswitch functioning while in the editor, but no longer working when built.

[protodeep]

@mmenicutch @RandomOutput For the BugReporter recording, pressing the left shift key unlocks the tab key. No UI for this at runtime, but there is an enum in the editor on the BugReporter that explains this behavior.

[RandomOutput]

@mmenicutch f16ee39 and 3e6bb11 should address the bug reporter instructions being wrong, and the moving demo no longer having wasd and mouse look.

[RandomOutput]

@mmenicutch 499eb13 should resolve quick switch working in editor but not in build.

[Amarcolina]

I'm getting warnings for unused vars in SystemWipeRecogniser, for m_wipeInfoDirty and wipeInfoLock

[Amarcolina]

I start a new empty scene, and drop the LMHeadMountedRig into the scene. It defaults to the AR_WORLD_AR_HANDS configuration, but the background quad is being overwritten by the skybox. In AR mode the cameras clear flags should be set to Color Only instead of Skybox.

[Amarcolina]

When using VR_WORLD_AR_HANDS config, when shaking my head I am getting some weird artifacts with the image hand.

[Amarcolina]

I built an exe of SpaceTimeAlignment and I believe I understand what is causing the artifacts. It can be noticed by using the dragonfly (I made sure to override the device type just in case) and turning on the tracked skeleton. I am noticing that the tracked skeleton slides relative to the image of the hand when I move my head. This can sometimes lead to the image highlight sliding right off the hand (as seen above). I think that what is happening is that the images are being timewarped (leading to them lining up with virtual objects), but the hand controller itself is not being rewound, so objects that are a child of the hand controller are still stuck in the wrong coordinate space and do not line up properly.

[RandomOutput]

@Amarcolina 149cdf2 should resolve the system wipe recognizer warnings.

[RandomOutput]

@Amarcolina In 34f4c7a, Advanced Mode is refactored in the manner we discussed. Give it a shot when you have a moment.

[Amarcolina]

One small change that might be nice, if you add m_Script to the list of basic names, which will allow the default script field to show up even if advanced mode is off. Also AdvancedMode.cs is currently a MonoBehaviour, it should probably be a static class.

[RandomOutput]

@Amarcolina resolved in a1970c1

[Amarcolina]

That looks great! The cameras still have their clear flags set to skybox for AR_WORLD mode, which is preventing the quad background from showing through when there is a skybox. Also im not sure when it happened but it seems the left and right cameras of the camera alignment in the prefab are unsigned.

[RandomOutput]

@Amarcolina Fixed the clear flags in 53fd5c8.